From d768c334cbca19add262de6ae6817f2aa224e36a Mon Sep 17 00:00:00 2001 From: David Bomba Date: Tue, 17 Aug 2021 18:45:00 +1000 Subject: [PATCH] Fixes for line items --- app/Utils/Traits/CleanLineItems.php | 9 ++++++--- tests/Integration/CompanyLedgerTest.php | 3 ++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/app/Utils/Traits/CleanLineItems.php b/app/Utils/Traits/CleanLineItems.php index 6aa299066..0a67659b8 100644 --- a/app/Utils/Traits/CleanLineItems.php +++ b/app/Utils/Traits/CleanLineItems.php @@ -56,9 +56,12 @@ trait CleanLineItems $item[$key] = BaseSettings::castAttribute(InvoiceItem::$casts[$key], $item[$key]); } - if($item['type_id'] == '0') - $item['type_id'] ='1'; - + if(array_key_exists('type_id', $item) && $item['type_id'] == '0') + $item['type_id'] = '1'; + + if(!array_key_exists('type_id', $item)) + $item['type_id'] = '1'; + } if (array_key_exists('id', $item)) { diff --git a/tests/Integration/CompanyLedgerTest.php b/tests/Integration/CompanyLedgerTest.php index d50030a00..e09be58ac 100644 --- a/tests/Integration/CompanyLedgerTest.php +++ b/tests/Integration/CompanyLedgerTest.php @@ -158,7 +158,8 @@ class CompanyLedgerTest extends TestCase $item = []; $item['quantity'] = 1; $item['cost'] = 10; - + $item['type_id'] = "1"; + $line_items[] = $item; $data = [